[ https://issues.apache.org/jira/browse/PHOENIX-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508747#comment-16508747 ]
ASF GitHub Bot commented on PHOENIX-3955: ----------------------------------------- Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/304#discussion_r194544646 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java --- @@ -651,6 +653,10 @@ public static String getJdbcUrl(RegionCoprocessorEnvironment env) { + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkParentNode; } + public static boolean isPropertyAllowedToBeOutOfSyncAmongColFamsAndIndexes(String colFamProp) { --- End diff -- Just return .contains since the callers always negate the boolean returned by this function. > Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL properties stay in sync > between the physical data table and index tables > ------------------------------------------------------------------------------------------------------------------------------ > > Key: PHOENIX-3955 > URL: https://issues.apache.org/jira/browse/PHOENIX-3955 > Project: Phoenix > Issue Type: Bug > Reporter: Samarth Jain > Assignee: Chinmay Kulkarni > Priority: Major > > We need to make sure that indexes inherit the REPLICATION_SCOPE, > KEEP_DELETED_CELLS and TTL properties from the base table. Otherwise we can > run into situations where the data was removed (or not removed) from the data > table but was removed (or not removed) from the index. Or vice-versa. We also > need to make sure that any ALTER TABLE SET TTL or ALTER TABLE SET > KEEP_DELETED_CELLS statements propagate the properties to the indexes too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)