Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201741221
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2147,46 +2566,29 @@ private MetaDataMutationResult doDropTable(byte[]
key, byte[] tenantId, byte[] s
}
if (tableType == PTableType.TABLE || tableType ==
PTableType.SYSTEM) {
- // Handle any child views that exist
- TableViewFinder tableViewFinderResult =
findChildViews(region, tenantId, table, clientVersion, !isCascade);
- if (tableViewFinderResult.hasViews()) {
- if (isCascade) {
- if
(tableViewFinderResult.allViewsInMultipleRegions()) {
- // We don't yet support deleting a table with
views where SYSTEM.CATALOG has split and the
- // view metadata spans multiple regions
- return new
MetaDataMutationResult(MutationCode.UNALLOWED_TABLE_MUTATION,
-
EnvironmentEdgeManager.currentTimeMillis(), null);
- } else if
(tableViewFinderResult.allViewsInSingleRegion()) {
- // Recursively delete views - safe as all the
views as all in the same region
- for (ViewInfo viewInfo :
tableViewFinderResult.getViewInfoList()) {
- byte[] viewTenantId =
viewInfo.getTenantId();
- byte[] viewSchemaName =
viewInfo.getSchemaName();
- byte[] viewName = viewInfo.getViewName();
- byte[] viewKey =
SchemaUtil.getTableKey(viewTenantId, viewSchemaName, viewName);
- Delete delete = new Delete(viewKey,
clientTimeStamp);
- rowsToDelete.add(delete);
- acquireLock(region, viewKey, locks);
- MetaDataMutationResult result =
doDropTable(viewKey, viewTenantId, viewSchemaName,
- viewName, null, PTableType.VIEW,
rowsToDelete, invalidateList, locks,
- tableNamesToDelete,
sharedTablesToDelete, false, clientVersion);
- if (result.getMutationCode() !=
MutationCode.TABLE_ALREADY_EXISTS) { return result; }
- }
- }
- } else {
+ // check to see if the table has any child views
+ try (Table hTable =
+ env.getTable(SchemaUtil.getPhysicalTableName(
+
PhoenixDatabaseMetaData.SYSTEM_CHILD_LINK_NAME_BYTES,
+ env.getConfiguration()))) {
+ boolean hasChildViews =
+ ViewFinder.hasChildViews(hTable, tenantId,
schemaName, tableName,
+ clientTimeStamp);
+ if (hasChildViews && !isCascade) {
--- End diff --
I think we can handle the race condition in a similar way to how we handle
conflicting columns using checkAndMutate. I have updated PHOENIX-4799 to
include this case.
---
