Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r201745438 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -3642,30 +3596,62 @@ private void dropIndexes(PTable table, Region region, List<ImmutableBytesPtr> in boolean isCoveredColumn = indexMaintainer.getCoveredColumns().contains(colDropRef); // If index requires this column for its pk, then drop it if (isColumnIndexed) { - // Since we're dropping the index, lock it to ensure - // that a change in index state doesn't - // occur while we're dropping it. - acquireLock(region, indexKey, locks); // Drop the index table. The doDropTable will expand // this to all of the table rows and invalidate the // index table - additionalTableMetaData.add(new Delete(indexKey, clientTimeStamp)); + Delete delete = new Delete(indexKey, clientTimeStamp); byte[] linkKey = MetaDataUtil.getParentLinkKey(tenantId, schemaName, tableName, index .getTableName().getBytes()); - // Drop the link between the data table and the + // Drop the link between the parent table and the // index table - additionalTableMetaData.add(new Delete(linkKey, clientTimeStamp)); - doDropTable(indexKey, tenantId, index.getSchemaName().getBytes(), index - .getTableName().getBytes(), tableName, index.getType(), - additionalTableMetaData, invalidateList, locks, tableNamesToDelete, sharedTablesToDelete, false, clientVersion); - invalidateList.add(new ImmutableBytesPtr(indexKey)); + Delete linkDelete = new Delete(linkKey, clientTimeStamp); + List<Mutation> tableMetaData = Lists.newArrayListWithExpectedSize(2); + Delete tableDelete = delete; + tableMetaData.add(tableDelete); + tableMetaData.add(linkDelete); + // if the index is not present on the current region make an rpc to drop it --- End diff -- This is to handle dropping indexes on views. We could drop a column on a base table which is used by an index on view which could be on a separate region.
---