My recollection (or maybe it was just my assumption) was that they were created to provide/facilitate compatibility with Windows.
- Gabriel On Tue, Jan 14, 2020 at 3:22 AM Josh Elser <[email protected]> wrote: > > Do you recall why they were converted? I can also go digging in > Jira/Mail archives. > > On 1/12/20 9:11 PM, [email protected] wrote: > > Heh. > > They used to be shell scripts and then we converted them to > > Python.Personally I was not a fan of that back then, but anyway. > > In any case there's some work to do. > > > > -- Lars > > > > On Friday, January 10, 2020, 7:55:43 AM PST, Josh Elser > > <[email protected]> wrote: > > > > I think converting them to Bash is the right thing to do. We're not > > doing anything fancy. > > > > On 1/9/20 5:10 PM, Andrew Purtell wrote: > >> Some of the python scripts are glorified shell scripts and could be > >> rewritten as such, such as the launch scripts for psql and sqlline and the > >> pqs. I get that python is and was trendier than bash but sometimes the > >> right tool for the job is the right tool for the job. Unlike python, bash > >> has a very stable grammar. > >> > >> On Thu, Jan 9, 2020 at 12:34 PM [email protected] <[email protected]> wrote: > >> > >>> Hi all, > >>> > >>> python2 is officially EOL'd. No more changes, improvements, or fixes will > >>> be done by the developers. > >>> Some Linux distributions stopped shipping Python2. > >>> > >>> It turns out our scripts do not work with Python3, see: [PHOENIX-5656] > >>> Make Phoenix scripts work with Python 3 - ASF JIRA. > >>> > >>> [PHOENIX-5656] Make Phoenix scripts work with Python 3 - ASF JIRA > >>> > >>> So what should we do? > >>> > >>> As outlined in the jira we have 3 options: > >>> > >>> 1. Do nothing. Phoenix will only work with EOL'd Python 2. > >>> 2. try to make all the scripts work with Python 2 and 3. That's > >>> actually not possible in cases, but we can get close... And it's a lot of > >>> work and experimentation. > >>> 3. Convert all scripts to Python 3. There's a tool (2to3) to do > >>> that > >>> automatically. Phoenix will now _only_ work with Python 3. > >>> > >>> Option 2 is some work - some of it not trivial - that someone would need > >>> to pick up. Perhaps we can maintain two versions of all scripts, figure > >>> out > >>> the version of Python and the use right one? > >>> > >>> Let's discuss on the jira. I can't be only one interested in this :) > >>> > >>> Cheers. > >>> > >>> -- Lars > >>> > >> > >> > > > >
