Istvan, Harmonizing the uses of guava between the two branches makes a lot of sense. The current differences add to the merge conflicts when porting a significant change between the branches, and make it easy to mistakenly use an unshaded version of guava in the master branch (as I accidentally did once. :-) )
The main question I see is when to do it -- before the upcoming 4.16 release or afterward for a 4.16.1 or 4.17? That depends on release timing. Geoffrey On Tue, Nov 24, 2020 at 7:07 AM Istvan Toth <st...@apache.org> wrote: > Hi! > > I'd like to gather your opinion on replacing Guava with the > phoenix-thirdparty shaded version on the 4.x branch. > > The change was not applied on 4.x, as the incompatibilities that the > pre-shaded Guava version solves are not present on Hadoop 2/Hbase 1. > However, the difference between the branches causes extra work, and > frequent problems when porting code between the branches. > Applying PHOENIX-6010 to the 4.x branch would make our lives easier, while > having no negative effects that I know of (we already pull in > phoenix-thirdparty via Omid 1.0.2) > > looking forward to hearing your opinion > Istvan >
