Hi! I'm slightly leaning towards getting the more impactful fixes already in 5.1.1 RC2 released, rather than iterating more on it, but for now I'm going to take a passive role, and leave the decision to the PMC. We have two binding +2s at the moment, so I'll just follow procedure, and make the decision based on the next binding vote.
Istvan On Sat, Mar 20, 2021 at 7:30 PM la...@apache.org <la...@apache.org> wrote: > PHOENIX-6423 could be blocker...? > > What happens is that SELECT * queries with mixed default and explicit > column families would return the wrong set of columns. > And in some situation the WHERE clause evaluation would fail. > > I'm fine either way. > > -- Lars > > > > On Friday, March 19, 2021, 7:04:08 PM PDT, la...@apache.org < > la...@apache.org> wrote: > > > > > > If 5.1.1 is sunk for any reason, I'd like to get PHOENIX-6421 in. (By > itself it's not enough to sink the release, I think) > > > On Wednesday, March 17, 2021, 8:53:59 PM PDT, Xinyi Yan < > yanxi...@apache.org> wrote: > > > > > > +1 (non-binding) > > Besides the signature, checksum, and mvn install/verify, I built from the > source and loaded the jar to my local environment. Create table/view/tenant > view, upsert and select queries are working as expected. > > On Wed, Mar 17, 2021 at 8:32 PM Viraj Jasani <vjas...@apache.org> wrote: > > > +1 (non-binding) > > > > * Signature: ok > > * Checksum : ok > > * Rat check (1.8.0_171): ok > > - mvn clean apache-rat:check > > * Built from source (1.8.0_171): ok > > - mvn clean install -DskipTests > > * Basic CRUD testing locally: ok > > * Unit tests pass (1.8.0_171): failed (few flakes, passed in subsequent > > run) > > - mvn clean package && mvn verify -Dskip.embedded > > > > > > On Tue, 16 Mar 2021 at 8:58 PM, Istvan Toth <st...@apache.org> wrote: > > > > > Please vote on this Apache phoenix release candidate, > > > phoenix-5.1.1RC2 > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > [ ] +1 Release this package as Apache phoenix 5.1.1 > > > [ ] -1 Do not release this package because ... > > > > > > The tag to be voted on is 5.1.1RC2: > > > > > > https://github.com/apache/phoenix/tree/5.1.1RC2 > > > > > > The release files, including signatures, digests, as well as CHANGES.md > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-5.1.1RC2/ > > > > > > Maven artifacts are available in a staging repository at: > > > > > > https://repository.apache.org/#stagingRepositories > > > (orgapachephoenix-1229) > > > > > > Artifacts were signed with the 0x794433C7 key which can be found in: > > > > > > https://dist.apache.org/repos/dist/release/phoenix/KEYS > > > > > > To learn more about Apache phoenix, please see > > > > > > http://phoenix.apache.org/ > > > > > > Thanks, > > > Istvan > > > > > >