stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r940369614


##########
common/src/main/java/org/apache/omid/YAMLUtils.java:
##########
@@ -64,7 +64,6 @@ public Map loadSettings(String resourcePath, String 
defaultResourcePath) throws
         return defaultSetting;
     }
 
-    @SuppressWarnings("unchecked")

Review Comment:
   If removing it doesn't cause a warning, the we should, if it does, we should 
keep it.
   I haven't checked if it's really needed or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to