stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r945523712
##########
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##########
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
private boolean skipCellVersion(Cell cell) {
return skipColumn != null
- && CellUtil.matchingRow(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
+ && PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
Review Comment:
Yes.
If you need to copy some code from the IA.Private classes, please add a
comment to the copied code that explains why it was copied, and where is the
original code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
