[
https://issues.apache.org/jira/browse/OMID-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694442#comment-17694442
]
ASF GitHub Bot commented on OMID-239:
-------------------------------------
richardantal commented on code in PR #129:
URL: https://github.com/apache/phoenix-omid/pull/129#discussion_r1118802873
##########
hbase-common/src/main/java/org/apache/omid/tools/hbase/X509Util.java:
##########
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.omid.tools.hbase;
+
+import io.netty.handler.ssl.SslContext;
+import io.netty.handler.ssl.SslContextBuilder;
+import org.apache.hbase.thirdparty.com.google.common.collect.ObjectArrays;
+import org.apache.yetus.audience.InterfaceAudience;
Review Comment:
No, I'll delete these lines.
##########
transaction-client/pom.xml:
##########
@@ -135,6 +151,16 @@
<artifactId>testng</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.omid</groupId>
+ <artifactId>omid-hbase-common</artifactId>
+ <version>${project.version}</version>
+ <scope>compile</scope>
+ </dependency>
+ <dependency>
Review Comment:
Turns out it is not needed afterall
> OMID TLS support
> ----------------
>
> Key: OMID-239
> URL: https://issues.apache.org/jira/browse/OMID-239
> Project: Phoenix Omid
> Issue Type: Task
> Reporter: Richárd Antal
> Assignee: Richárd Antal
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
