[
https://issues.apache.org/jira/browse/OMID-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695124#comment-17695124
]
ASF GitHub Bot commented on OMID-239:
-------------------------------------
stoty commented on code in PR #129:
URL: https://github.com/apache/phoenix-omid/pull/129#discussion_r1121843444
##########
tso-server/src/main/java/org/apache/omid/tso/TSOChannelHandler.java:
##########
@@ -49,8 +49,13 @@
import io.netty.handler.codec.LengthFieldPrepender;
import io.netty.handler.codec.protobuf.ProtobufDecoder;
import io.netty.handler.codec.protobuf.ProtobufEncoder;
+import io.netty.handler.ssl.OptionalSslHandler;
+import io.netty.handler.ssl.SslContext;
import io.netty.util.AttributeKey;
import io.netty.util.concurrent.GlobalEventExecutor;
+import org.apache.omid.tls.X509Util;
+import org.apache.zookeeper.common.X509Exception;
Review Comment:
Please make copy of this Exception.
##########
common/pom.xml:
##########
@@ -104,6 +104,41 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>zookeeper</artifactId>
+ <version>${zookeeper.version}</version>
+ </dependency>
+
+ <dependency>
Review Comment:
Shouldn't this be test scope ?
##########
common/pom.xml:
##########
@@ -104,6 +104,41 @@
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
As I said elsewhere, we should copy the exceptions, so we shouldn't depend
on ZK here.
> OMID TLS support
> ----------------
>
> Key: OMID-239
> URL: https://issues.apache.org/jira/browse/OMID-239
> Project: Phoenix Omid
> Issue Type: Task
> Reporter: Richárd Antal
> Assignee: Richárd Antal
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
