I think we should look into this a bit deeper. Why does this fail with IPv6 ?
Are we explicitly binding TSO to the IPv4 address only ? Do we only do that in the tests, or does that happen in production ? Is it even possible to use Omid with IPv6 ? I suspect that fixing https://issues.apache.org/jira/browse/OMID-249 would improve on this. Generally, I think that having a single IP per TSO can be a problem in a mixed IPv4 / IPv6 network, and with some network configurations. Maybe we should store the name of the active server instead of addresses in ZK, and kick this problem down to the network/DNS administrator. If Omid is known to not work with IPV6 in 1.1.0 , then I'm OK with Cong's proposed solution, but if it breaks pre-existing Ipv6 support, then we should fix this properly for 1.1.1. We should create a follow-up ticket to make sure the Omid is IPv6 clean for the next release at the very least. Istvan On Thu, Jan 18, 2024 at 6:56 AM Cong Luo <l...@apache.org> wrote: > Hi Richard, > Actually, I had the same issue before, but it was resolved locally: if > the NIC was assigned both ipv4 and ipv6 addresses, use ipv4 first. If we > all think this is acceptable, then I will create a PR submission. > > On 2024/01/17 14:30:50 Richárd Antal wrote: > > -1 > > > > Signature: OK > > Checksum: OK > > mvn clean apache-rat:check: OK > > > > Changes and release notes: OK > > > > Built from source (1.8.0_241): OK > > - mvn clean install -DskipTests > > Ran tests on my MacBook locally: > > - mvn clean verify : Failed > > TestTSOClientConnectionToTSO had failing tests: > > testSuccessfulConnectionToTSOThroughZK and > > testSuccessOfTSOClientReconnectionsToARestartedTSOWithZKPublishing > > It might be because it uses IPv6 > > Some logs > > > > 2024-01-17T15:17:45,858 INFO > > > [TestNGInvoker-testSuccessfulConnectionToTSOThroughZK()] > client.TSOClient: > > > * Current TSO host:port found in ZK: > > > [fe80:0:0:0:aede:48ff:fe00:1122%en5]:52934 Epoch 0 > > > 2024-01-17T15:17:45,859 INFO [tsofsm-0] client.TSOClient: Trying to > > > connect to TSO [/fe80:0:0:0:aede:48ff:fe00:1122%en5:52934] > > > 2024-01-17T15:17:45,863 ERROR [tsoclient-worker-0] client.TSOClient: > > > Failed connection attempt to TSO > > > [/fe80:0:0:0:aede:48ff:fe00:1122%en5:52934] failed. Channel [id: > 0x9d8c0b44] > > > > > > I’ve also tested the TestTSOClientConnectionToTSO on the 1.1.0 release > > locally and that was successful (It used IPv4). > > I think this is a regression on Mac and it would be nice to fix before > the > > release. > > > > Richard > > > > Cong Luo <l...@apache.org> ezt írta (időpont: 2024. jan. 11., Cs, 3:52): > > > > > +1 > > > > > > I did a basic test last month in the test environment (fully > distributed) > > > based on phoenix 5.1.3 + omid 1.1.1 and did not find a blocking issue. > > > > > > On 2024/01/09 12:53:28 "rajeshb...@apache.org" wrote: > > > > Please vote on this Apache phoenix omid release candidate, > > > > phoenix-omid-1.1.1RC0 > > > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > > > [ ] +1 Release this package as Apache phoenix omid 1.1.1 > > > > [ ] -1 Do not release this package because ... > > > > > > > > The tag to be voted on is 1.1.1RC0: > > > > > > > > https://github.com/apache/phoenix-omid/tree/1.1.1RC0 > > > > > > > > The release files, including signatures, digests, as well as > CHANGES.md > > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-omid-1.1.1RC0/ > > > > > > > > Maven artifacts are available in a staging repository at: > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachephoenix-1251/ > > > > > > > > Artifacts were signed with the 0x2CC0FD99 key which can be found in: > > > > > > > > https://dist.apache.org/repos/dist/release/phoenix/KEYS > > > > > > > > To learn more about Apache phoenix omid, please see > > > > > > > > https://phoenix.apache.org/ > > > > > > > > Thanks, > > > > Rajeshbabu. > > > > > > > > > > -- *István Tóth* | Sr. Staff Software Engineer *Email*: st...@cloudera.com cloudera.com <https://www.cloudera.com> [image: Cloudera] <https://www.cloudera.com/> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> ------------------------------ ------------------------------
