[
https://issues.apache.org/jira/browse/OMID-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823503#comment-17823503
]
Istvan Toth commented on OMID-284:
----------------------------------
Thank you, please do.
I think that moving to Protobuf 3 is uncontroversial (barring unlikely
compatibility issues), Protobuf 2.5 has CVEs, and we only keep using it in
Phoenix because we have to (at least for HBase 2.x).
OMID-276 is a bit more controversial. It ensures that we don't conflict with
other protobuf 3 libraries coming from Spark, Hadoop, etc, but we'd be also
using a library that we were not really meant to.
I'd first move to standard protobuf 3, and then consider moving to the
hbase-thirdparty one in a scend step after discussing it a bit more.
> Use protobuf 3 in Omid
> ----------------------
>
> Key: OMID-284
> URL: https://issues.apache.org/jira/browse/OMID-284
> Project: Phoenix Omid
> Issue Type: Improvement
> Affects Versions: 1.1.2
> Reporter: Istvan Toth
> Assignee: Nihal Jain
> Priority: Critical
>
> Omid uses Protobuf 2.5.0.
> It only uses protobuf for communicating with the TSO server, it does not
> implement an HBase endpoint, so I see no reason not to use the latest version.
> This could be done in 1.2, provided that the switch does not cause
> compatibility issues (I expect none)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)