[
https://issues.apache.org/jira/browse/OMID-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889770#comment-17889770
]
ASF GitHub Bot commented on OMID-284:
-------------------------------------
NihalJain commented on code in PR #170:
URL: https://github.com/apache/phoenix-omid/pull/170#discussion_r1801631351
##########
common/src/main/proto/TSOProto.proto:
##########
@@ -16,51 +16,51 @@
// limitations under the License.
//
+syntax = "proto3";
Review Comment:
any reason for building with proto3? hbase still uses proto2 even though
builds with proto 4.8.2?
> Use protobuf 3 in Omid
> ----------------------
>
> Key: OMID-284
> URL: https://issues.apache.org/jira/browse/OMID-284
> Project: Phoenix Omid
> Issue Type: Improvement
> Affects Versions: 1.1.2
> Reporter: Istvan Toth
> Assignee: Nihal Jain
> Priority: Critical
>
> Omid uses Protobuf 2.5.0.
> It only uses protobuf for communicating with the TSO server, it does not
> implement an HBase endpoint, so I see no reason not to use the latest version.
> This could be done in 1.2, provided that the switch does not cause
> compatibility issues (I expect none)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
