[
https://issues.apache.org/jira/browse/PHOENIX-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917800#comment-13917800
]
James Taylor commented on PHOENIX-53:
-------------------------------------
Can you try making the changes to your local git repo, and then just doing the
following to produce the patch instead?
{code}
git diff > newCSVLoader.patch
{code}
And then just attach this to the bug? Please make sure you have the latest
first and that the unit tests pass after your change. I'll make sure to apply
the patch once you attach it before other changes are made in the repo.
Thanks!
> CSV loader fails on empty line
> ------------------------------
>
> Key: PHOENIX-53
> URL: https://issues.apache.org/jira/browse/PHOENIX-53
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 2.2.3, 3.0.0
> Reporter: James Violette
> Labels: patch
> Fix For: 2.2.3, 3.0.0
>
> Attachments: commons-csv-1.0-SNAPSHOT.jar,
> incubator-phoenix-commons-csv-rev1.patch,
> incubator-phoenix-commons-csv-rev2-3.0.0.patch,
> incubator-phoenix-csv-commons.patch
>
>
> in org.apache.phoenix.util.CSVLoader, the upsert fails if it encounters an
> empty line. This occurs if all lines end with the new line character and the
> reader returns an empty line at the end.
> A fix is to add a guard while reading the next line.
> public void upsert(CSVReader reader) throws Exception {
> ...
> while ((nextLine = reader.readNext()) != null) {
> if (nextLine.length==0) {
> continue;
> }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
