[
https://issues.apache.org/jira/browse/PHOENIX-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918425#comment-13918425
]
James Violette commented on PHOENIX-53:
---------------------------------------
Just created the patch per your instructions, applied it to the master on my
machine, and am now running the full suite of phoenix-core tests. I had the
latest to start with. The Eclipse patch tool picks up stray files that I had
to manually remove (mvn eclipse xml files). The command line allowed me to
pick up only the committed changes...
On my csv loader branch, I ran
$ git diff HEAD~1 HEAD > patch
Then, I checked out master and applied the patch to the base code
$ git apply patch
Now, I am running the tests using
$ mvn package
> CSV loader fails on empty line
> ------------------------------
>
> Key: PHOENIX-53
> URL: https://issues.apache.org/jira/browse/PHOENIX-53
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 2.2.3, 3.0.0
> Reporter: James Violette
> Labels: patch
> Fix For: 2.2.3, 3.0.0
>
> Attachments: commons-csv-1.0-SNAPSHOT.jar,
> incubator-phoenix-commons-csv-rev1.patch,
> incubator-phoenix-commons-csv-rev2-3.0.0.patch,
> incubator-phoenix-csv-commons.patch
>
>
> in org.apache.phoenix.util.CSVLoader, the upsert fails if it encounters an
> empty line. This occurs if all lines end with the new line character and the
> reader returns an empty line at the end.
> A fix is to add a guard while reading the next line.
> public void upsert(CSVReader reader) throws Exception {
> ...
> while ((nextLine = reader.readNext()) != null) {
> if (nextLine.length==0) {
> continue;
> }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
