Github user jyates commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/14#issuecomment-36813231
> Didn't understand your last comment. Please elaborate?
You mean this one:
> Some issues around license formatting though :)
Because the licenses are getting compressed together, when there needs to
be a lot of whitespace. Orrrrr, you are making fun of me, in which case, yeah,
I get it, I'll be better in the future :)
Or this:
> This shouldn't have the index writing issue (that goes directly to the
local HRegion, if its on this server, whose memstore will barf on the
ClientKeyValue) as the codec isn't using the clientkeyvaluebuilder.
You'd emailed me about an issue with the index writes still using the
ClientKeyValue and that breaking when it did a local write (HRegion present on
the same server) since the MemStore needs to read KeyValues. With using the
GenericKeyValueBuilder everywhere on the server (including the
PhoenixIndexCodec) this shouldn't be a problem anymore, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
