Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/14#discussion_r10328087
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixIndexCodec.java ---
@@ -70,7 +71,9 @@ public void initialize(RegionCoprocessorEnvironment env) {
// server
conf.setIfUnset(IndexWriter.INDEX_FAILURE_POLICY_CONF_KEY,
PhoenixIndexFailurePolicy.class.getName());
- this.builder = KeyValueBuilder.get(env.getHBaseVersion());
+ // We cannot use the ClientKeyValueBuilder because when these hit
the memstore
--- End diff --
Would this just be a few lines of code? In ParallelWriterIndexCommitter:114
plus having a method on ClientKeyValue that copies the KeyValues and returns
the new List<Mutation>?
final List<Mutation> mutations = (List<Mutation>) entry.getValue();
// Pass the list through to the KeyValueBuilder to potentially make
copies of them, as
// the memstore requires the KeyValue to have a backing buffer
mutations = kvBuilder.copyMutationsIfNecessary(mutations);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
