Github user prashantkommireddi commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/27#discussion_r11406303
  
    --- Diff: 
phoenix-pig/src/main/java/org/apache/phoenix/pig/PhoenixPigConfiguration.java 
---
    @@ -58,106 +65,232 @@
        
        public static final String TABLE_NAME = "phoenix.hbase.table.name";
        
    +   public static final String UPSERT_COLUMNS = 
"phoenix.hbase.upsert.columns";
    +   
        public static final String UPSERT_STATEMENT = "phoenix.upsert.stmt";
        
    +   public static final String UPSERT_COLUMN_INFO_KEY  = 
"phoenix.upsert.columninfos.list";
    +   
    +   public static final String SELECT_STATEMENT = "phoenix.select.stmt";
    +   
        public static final String UPSERT_BATCH_SIZE = 
"phoenix.upsert.batch.size";
        
    +   //columns projected given as part of LOAD.
    +   public static final String SELECT_COLUMNS = 
"phoneix.select.query.columns";
    +   
    +   public static final String SELECT_COLUMN_INFO_KEY  = 
"phoenix.select.columninfos.list";
    +   
    +   // the delimiter supported during LOAD and STORE when projected columns 
are given.
    +   public static final String COLUMN_NAMES_DELIMITER = 
"phoenix.column.names.delimiter";
    +   
        public static final long DEFAULT_UPSERT_BATCH_SIZE = 1000;
        
    -   private final Configuration conf;
    +   public static final String DEFAULT_COLUMN_NAMES_DELIMITER = ",";
        
    -   private Connection conn;
    -   private List<ColumnInfo> columnMetadataList;
    +   private final Configuration conf;
                
        public PhoenixPigConfiguration(Configuration conf) {
                this.conf = conf;
    +           this.util = new PhoenixPigConfigurationUtil();
        }
        
        public void configure(String server, String tableName, long batchSize) {
    -           conf.set(SERVER_NAME, server);
    -           conf.set(TABLE_NAME, tableName);
    -           conf.setLong(UPSERT_BATCH_SIZE, batchSize);
    -           conf.setBoolean(MAP_SPECULATIVE_EXEC, false);
    -           conf.setBoolean(REDUCE_SPECULATIVE_EXEC, false);
    +        configure(server,tableName,batchSize,null);
    +    }
    +   
    +   public void configure(String server, String tableName, long batchSize, 
String columns) {
    +       conf.set(SERVER_NAME, server);
    +        conf.set(TABLE_NAME, tableName);
    --- End diff --
    
    Indentations is off


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to