Github user mravi commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/27#discussion_r11454668
--- Diff:
phoenix-pig/src/main/java/org/apache/phoenix/pig/PhoenixPigConfiguration.java
---
@@ -18,32 +18,39 @@
package org.apache.phoenix.pig;
+import static org.apache.commons.lang.StringUtils.isNotEmpty;
+
import java.sql.Connection;
import java.sql.DriverManager;
-import java.sql.ResultSet;
import java.sql.SQLException;
-import java.util.ArrayList;
import java.util.List;
import java.util.Properties;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration;
-
import org.apache.phoenix.jdbc.PhoenixConnection;
import org.apache.phoenix.util.ColumnInfo;
+import org.apache.phoenix.util.PhoenixRuntime;
import org.apache.phoenix.util.QueryUtil;
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Joiner;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Splitter;
+import com.google.common.collect.Lists;
+
+
/**
- * A container for configuration to be used with {@link
PhoenixHBaseStorage}
- *
- *
+ * A container for configuration to be used with {@link
PhoenixHBaseStorage} and {@link PhoenixHBaseLoader}
*
*/
public class PhoenixPigConfiguration {
private static final Log LOG =
LogFactory.getLog(PhoenixPigConfiguration.class);
+ private PhoenixPigConfigurationUtil util;
--- End diff --
To enable us to do mocks , I plan to have a setter method
setUtil(PhoenixPigConfigurationUtil). Hence, i don't have it as final.
This way , we can improve code coverage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
