[ 
https://issues.apache.org/jira/browse/PIG-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969435#action_12969435
 ] 

Alan Gates commented on PIG-1479:
---------------------------------

Comments and questions:

This patch makes changes to the public interface 
PigProgressNotificationListener.  It's ok, since it's marked evolving.  Do we 
know how many people are using this and what we'll need to do to mitigate the 
changes for them?

PigPipeline needs better javadoc comments at the class level.  The current 
javadocs confuse it with the defined Pig class.

Rather than the Pig class detailed in the design doc this patch has 
ScriptPigServer, which has a slightly different interface.  Does this represent 
a change to the design or is there a yet to be built Pig class?

Do we need two classes BoundPipeline and MultiBoundPipeline?  Could we instead 
have just BoundPipeline, and then for each run method there would be:

{code}
public List<PigStats> run()
public PigStats runSingle() {
    if (multijob) throw ...
    return run().get(0);
}
{code}

Then run is a valid call whether this is a single or multi-job situation, which 
means users don't have to write their code differently in situations where they 
are using both single and multi-job binds.  In simple cases where users know 
they only have one thing bound they can use the simpler runSingle call.  
Calling runSingle when multiple things are bound would be an error.

We need to mark the availability and stability of the ScriptEngine interface.  
I suspect it is Public Evolving.



> Embed Pig in scripting languages
> --------------------------------
>
>                 Key: PIG-1479
>                 URL: https://issues.apache.org/jira/browse/PIG-1479
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julien Le Dem
>            Assignee: Richard Ding
>             Fix For: 0.9.0
>
>         Attachments: PIG-1479.patch, PIG-1479_2.patch, PIG-1479_3.patch, 
> PIG-1479_4.patch, pig-greek-test.tar, pig-greek-test.tar, pig-greek.tgz
>
>
> It should be possible to embed Pig calls in a scripting language and let 
> functions defined in the same script available as UDFs.
> This is a spin off of https://issues.apache.org/jira/browse/PIG-928 which 
> lets users define UDFs in scripting languages.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to