> On 2010-12-10 10:40:46, Daniel Dai wrote: > > trunk/src/org/apache/pig/impl/logicalLayer/parser/QueryParser.jjt, line 969 > > <https://reviews.apache.org/r/154/diff/1/?file=1104#file1104line969> > > > > The QueryParser will go away in 0.9 release. We will switch the parser > > (https://issues.apache.org/jira/browse/PIG-1618) in couple of months. So > > shall we wait for the new parser? > > Lin Guo wrote: > Thanks a lot for your comments. > > Will the new QueryParser allow multi-lines in function arguments? If not, > can we add this as a requirement? > > Daniel Dai wrote: > Yes, feel free to comment on that Jira
I think it's worth having this change committed in the meantime, since it's something that can be easily backported into builds of 0.8 that are going to be used for a while. We'll use it, and I expect Cloudera will be happy to roll something like this in as well. - Dmitriy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/154/#review66 ----------------------------------------------------------- On 2010-12-09 01:26:33, Lin Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/154/ > ----------------------------------------------------------- > > (Updated 2010-12-09 01:26:33) > > > Review request for pig. > > > Summary > ------- > > Summary: > > We want to extend pig parser to allow function arguments to contain multiple > lines as well as string list, like > > STORE data INTO 'testOut' > USING storage.avro.AvroStorage ( > '{"debug": 5, > "data": "/user/lguo/testOut/ComponentActTracking4/part-m-00000.avro", > "field0": "int", > "field1": "def:browser_id", > "field3": "def:act_content" } ' > ); > > > This addresses bug PIG-1749. > https://issues.apache.org/jira/browse/PIG-1749 > > > Diffs > ----- > > trunk/src/org/apache/pig/impl/logicalLayer/parser/QueryParser.jjt 1040872 > trunk/test/org/apache/pig/test/TestParamSubPreproc.java 1040872 > > Diff: https://reviews.apache.org/r/154/diff > > > Testing > ------- > > [exec] > [exec] +1 overall. > [exec] > [exec] +1 @author. The patch does not contain any @author tags. > [exec] > [exec] +1 tests included. The patch appears to include 3 new or > modified tests. > [exec] > [exec] +1 javadoc. The javadoc tool did not generate any warning > messages. > [exec] > [exec] +1 javac. The applied patch does not increase the total > number of javac compiler warnings. > [exec] > [exec] +1 findbugs. The patch does not introduce any new Findbugs > warnings. > [exec] > [exec] +1 release audit. The applied patch does not increase the > total number of release audit warnings. > [exec] > [exec] > > > Thanks, > > Lin > >
