[ 
https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972283#action_12972283
 ] 

Xuefu Zhang commented on PIG-1618:
----------------------------------

Patch NewParser-9.patch includes second portion of logical plan generation. 
Still, work is not complete and subject to subsequent changes. 

The following is the test-patch run result. The additional javac warnings are 
due to generated code. Ant test passed.
     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 6 new or 
modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     -1 javac.  The applied patch generated 943 javac compiler 
warnings (more than the trunk's current 924 warnings).
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.



> Switch to new parser generator technology
> -----------------------------------------
>
>                 Key: PIG-1618
>                 URL: https://issues.apache.org/jira/browse/PIG-1618
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.8.0
>            Reporter: Alan Gates
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: antlr-3.2.jar, javadoc.patch, NewParser-1.patch, 
> NewParser-2.patch, NewParser-3.patch, NewParser-3.patch, NewParser-4.patch, 
> NewParser-5.patch, NewParser-6.patch, NewParser-7.patch, NewParser-8.patches, 
> NewParser-9.patch
>
>
> There are many bugs in Pig related to the parser, particularly to bad error 
> messages.  After review of Java CC we feel these will be difficult to address 
> using that tool.  Also, the .jjt files used by JavaCC are hard to understand 
> and maintain.  
> ANTLR is being reviewed as the most likely choice to move to, but other 
> parsers will be reviewed as well.
> This JIRA will act as an umbrella issue for other parser issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to