[
https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983452#action_12983452
]
Thejas M Nair commented on PIG-1618:
------------------------------------
NewParser-12.patch review comment :
For bag schema specification, the parser is ignoring the tuple name. ie in case
of bag schema such as "a : { t : (x : int)}", the tuple name "t" is being
ignored.
The name of the tuple in the bag is not useful because it cannot be accessed
with that name, so it makes sense to make it optional. But if we plan to ignore
the name (ie, describe command will not show the tuple name), i think we should
deprecate that syntax and warn the user.
ie something like -
{code}
grunt> l = load 'file' as (a : { t : (a : int)});
WARN: specifying name of the tuple in a bag is deprecated, the tuple name will
be ignored. Tuple inside the bag "a" has been named "t".
{code}
This change can be part of the next patch.
Committed NewParser-12.patch to trunk.
> Switch to new parser generator technology
> -----------------------------------------
>
> Key: PIG-1618
> URL: https://issues.apache.org/jira/browse/PIG-1618
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Alan Gates
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: antlr-3.2.jar, javadoc.patch, NewParser-1.patch,
> NewParser-10.patch, NewParser-11.patch, NewParser-12.patch,
> NewParser-2.patch, NewParser-3.patch, NewParser-3.patch, NewParser-4.patch,
> NewParser-5.patch, NewParser-6.patch, NewParser-7.patch, NewParser-8.patches,
> NewParser-9.patch
>
>
> There are many bugs in Pig related to the parser, particularly to bad error
> messages. After review of Java CC we feel these will be difficult to address
> using that tool. Also, the .jjt files used by JavaCC are hard to understand
> and maintain.
> ANTLR is being reviewed as the most likely choice to move to, but other
> parsers will be reviewed as well.
> This JIRA will act as an umbrella issue for other parser issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
