[
https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004868#comment-13004868
]
Thejas M Nair commented on PIG-1618:
------------------------------------
Review of NewParser-24.patch -
in SchemaAliasVisitor.validate() the check could be done in single loop if the
alias is stored in a HashSet and its presence is checked. That will reduce the
complexity.
I will make the change in a new patch.
NewParser-23.patch has unit test failure, I will submit new patch with fix,
which will include this change.
> Switch to new parser generator technology
> -----------------------------------------
>
> Key: PIG-1618
> URL: https://issues.apache.org/jira/browse/PIG-1618
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Alan Gates
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: NewParser-1.patch, NewParser-10.patch,
> NewParser-11.patch, NewParser-12.patch, NewParser-13.2.patch,
> NewParser-13.patch, NewParser-14.patch, NewParser-15.patch,
> NewParser-18.patch, NewParser-19.3.patch, NewParser-19.patch,
> NewParser-2.patch, NewParser-21.patch, NewParser-22.patch,
> NewParser-23.patch, NewParser-24.patch, NewParser-3.patch, NewParser-3.patch,
> NewParser-4.patch, NewParser-5.patch, NewParser-6.patch, NewParser-7.patch,
> NewParser-8.patches, NewParser-9.patch, antlr-3.2.jar, javadoc.patch
>
>
> There are many bugs in Pig related to the parser, particularly to bad error
> messages. After review of Java CC we feel these will be difficult to address
> using that tool. Also, the .jjt files used by JavaCC are hard to understand
> and maintain.
> ANTLR is being reviewed as the most likely choice to move to, but other
> parsers will be reviewed as well.
> This JIRA will act as an umbrella issue for other parser issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
