[
https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989940#comment-12989940
]
Thejas M Nair commented on PIG-1618:
------------------------------------
+1 NewParser-15.patch
Patch committed to trunk.
Some comments about the patch which can be addressed in next patch -
- in LogicalPlanGenerator.g, the exception InvalidScalarProjectionException
should include a useful error message as well.
{code}
+ if( schema != null && pos >= schema.size() ) {
+ throw new InvalidScalarProjectionException( input,
scalarExpr );
+ }
should be something like -
+ if( schema != null && pos >= schema.size() ) {
+ throw new InvalidScalarProjectionException( input,
scalarExpr, "Position " + pos + " is greater that schema size :" +
schema.size() );
+ }
{code}
- ScalarVisitor class description needs to be corrected.
> Switch to new parser generator technology
> -----------------------------------------
>
> Key: PIG-1618
> URL: https://issues.apache.org/jira/browse/PIG-1618
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Alan Gates
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: NewParser-1.patch, NewParser-10.patch,
> NewParser-11.patch, NewParser-12.patch, NewParser-13.2.patch,
> NewParser-13.patch, NewParser-14.patch, NewParser-15.patch,
> NewParser-2.patch, NewParser-3.patch, NewParser-3.patch, NewParser-4.patch,
> NewParser-5.patch, NewParser-6.patch, NewParser-7.patch, NewParser-8.patches,
> NewParser-9.patch, antlr-3.2.jar, javadoc.patch
>
>
> There are many bugs in Pig related to the parser, particularly to bad error
> messages. After review of Java CC we feel these will be difficult to address
> using that tool. Also, the .jjt files used by JavaCC are hard to understand
> and maintain.
> ANTLR is being reviewed as the most likely choice to move to, but other
> parsers will be reviewed as well.
> This JIRA will act as an umbrella issue for other parser issues.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
