[ 
https://issues.apache.org/jira/browse/PIG-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014929#comment-13014929
 ] 

Daniel Dai commented on PIG-1918:
---------------------------------

There are couple of other user facing places might need line number. Eg. 
LogicalSchema.merge(). As an incremental process, we can commit this patch 
first, and solve others later.

We can limit the usage of PlanValidationException to what its name suggests. 
Actually we intentionally make the exception structure simpler. Since 
PlanValidationException inherits VisitorException, we can limit the usage to 
Visitor only. In operator class (eg, ProjectExpression), maybe we can keep 
FrontendException, which means we need to add line number to FrontendException 
as well.

> Line number should be give for logical plan failures
> ----------------------------------------------------
>
>                 Key: PIG-1918
>                 URL: https://issues.apache.org/jira/browse/PIG-1918
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-1918-2.patch, PIG-1918.patch
>
>
> Currently, the line is only given for the cases where we encounter problem in 
> AST but not on the logical plan. It would be much more meaningful to users if 
> it covered both

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to