[ 
https://issues.apache.org/jira/browse/PIG-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016537#comment-13016537
 ] 

Thejas M Nair commented on PIG-1918:
------------------------------------

PIG-1918-4.patch review-
 The following constructor, is ignoring the Operator argument instead of adding 
the location to the message.
{code}
+    public FrontendException(Operator op, String message, int errCode, byte 
errSrc,
+            boolean retry, String detailedMsg, Throwable cause) {
+        super(message, errCode, errSrc, retry, detailedMsg, cause);
+    }
{code}
Everything else looks good.


> Line number should be give for logical plan failures
> ----------------------------------------------------
>
>                 Key: PIG-1918
>                 URL: https://issues.apache.org/jira/browse/PIG-1918
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-1918-2.patch, PIG-1918-4.patch, PIG-1918.patch
>
>
> Currently, the line is only given for the cases where we encounter problem in 
> AST but not on the logical plan. It would be much more meaningful to users if 
> it covered both

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to