[
https://issues.apache.org/jira/browse/PIG-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145158#comment-13145158
]
Daniel Dai commented on PIG-2337:
---------------------------------
Thanks for the patch. Couple of comments:
1. You cannot put logic in EvalFunc.setUDFContextSignature() and
EvalFunc.getUDFContextSignature(), user might override it. So don't save
signature in EvalFunc. You can do the serialization in
UserFuncExpression.getFieldSchema (You are quite there, except you need to use
the signature in UserFuncExpression). You can do the deserialization in
POUserFunc.instantiateFunc
2. prefix for the key:"pig.evalfunc.signature", better be
"pig.evalfunc.inputschema"
3. method name "autoGetInputSchema", better "getInputSchema",
"autoSetInputSchema", better "setInputSchema"
4. getInputSchema is user facing, should add some javadoc
> Provide UDF with input schema
> -----------------------------
>
> Key: PIG-2337
> URL: https://issues.apache.org/jira/browse/PIG-2337
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: xuting zhao
> Fix For: 0.11
>
> Attachments: PIG-2337-2.patch, PIG-2337.patch
>
>
> We have several requests to make input schema available to the UDF for
> inspection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
