[ 
https://issues.apache.org/jira/browse/PIG-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145738#comment-13145738
 ] 

xuting zhao commented on PIG-2337:
----------------------------------

Thanks for this comments.
The 2337-3.patch is the modified one. The changes including:
1. moving the store and retrieve actions of signature into UserFuncExpression 
and POUserFunc.
2. changing the prefix of the key to: "pig.evalfunc.inputshcmea."
3. adding javadoc into the getEFInputSchema.
4. I tried to change the function name of autoGetInputSchema and 
autoSetInputSchema to getInputSchema and setInputSchema. However, there seems 
some function in the jsFunction with the same name: private Schema 
getInputSchema(),private Schema setInputSchema(). So if I change to that name, 
there will be an error. As a result, I changed them to setEFInputSchema and 
getEFInputSchema()

ant commit-test and e2e test on the new test case: UDFContextAuto have been 
successfully run.
                
> Provide UDF with input schema
> -----------------------------
>
>                 Key: PIG-2337
>                 URL: https://issues.apache.org/jira/browse/PIG-2337
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Olga Natkovich
>            Assignee: xuting zhao
>             Fix For: 0.11
>
>         Attachments: PIG-2337-2.patch, PIG-2337-3.patch, PIG-2337.patch
>
>
> We have several requests to make input schema available to the UDF for 
> inspection. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to