[
https://issues.apache.org/jira/browse/PIG-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453613#comment-13453613
]
Dmitriy V. Ryaboy commented on PIG-2915:
----------------------------------------
Thanks Andy!
Brief notes:
1) Please add apache header on the new test file
2) Despite the fact that that's how the tests are currently organized, nothing
is restricting us to putting files into org.apache.pig.test -- we can just as
easily follow the more convenient method of putting them into the same package
as the class being tested. Move the new one?
3) There are a few existing tests for Top in TestBuiltin and Piggybank
(org.apache.pig.piggybank.test.evaluation.util.TestTop). Move them in here so
we get a complete picture, and ensure they still pass?
> Builtin TOP udf is sensitive to null input bags
> -----------------------------------------------
>
> Key: PIG-2915
> URL: https://issues.apache.org/jira/browse/PIG-2915
> Project: Pig
> Issue Type: Improvement
> Components: internal-udfs
> Affects Versions: 0.11
> Reporter: Andy Schlaikjer
> Assignee: Andy Schlaikjer
> Attachments: pig-null_safe_top.1.patch
>
>
> TOP(max, sortField, inputBag) is sensitive to null inputBag arguments.
> In some cases it is preferable for a UDF to simply return null for null
> inputs e.g. to avoid conditional logic in a script.
> Most of the UDFs I write act this way, but TOP does not. This patch updates
> TOP to return null in the case where all input bags are null. Unit tests are
> included to confirm expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
