[ 
https://issues.apache.org/jira/browse/PIG-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453649#comment-13453649
 ] 

Dmitriy V. Ryaboy commented on PIG-2915:
----------------------------------------

+1 will commit to trunk.
                
> Builtin TOP udf is sensitive to null input bags
> -----------------------------------------------
>
>                 Key: PIG-2915
>                 URL: https://issues.apache.org/jira/browse/PIG-2915
>             Project: Pig
>          Issue Type: Improvement
>          Components: internal-udfs
>    Affects Versions: 0.11
>            Reporter: Andy Schlaikjer
>            Assignee: Andy Schlaikjer
>         Attachments: pig-null_safe_top.1.patch, pig-null_safe_top.2.patch
>
>
> TOP(max, sortField, inputBag) is sensitive to null inputBag arguments.
> In some cases it is preferable for a UDF to simply return null for null 
> inputs e.g. to avoid conditional logic in a script.
> Most of the UDFs I write act this way, but TOP does not. This patch updates 
> TOP to return null in the case where all input bags are null. Unit tests are 
> included to confirm expected behavior.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to