[
https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485355#comment-13485355
]
Gianmarco De Francisci Morales commented on PIG-3006:
-----------------------------------------------------
I am fine with the changes, but it's a huge patch so I skimmed through it, I
might have missed something.
+0, let's wait for another pair of eyeballs.
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a
> couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4
> (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I
> replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on
> trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
