[
https://issues.apache.org/jira/browse/PIG-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cheolsoo Park updated PIG-3006:
-------------------------------
Attachment: PIG-3006-3.patch
I am running the unit test suite with this patch and like to commit this to
trunk unless anyone is planning to.
I noticed that the patch already doesn't apply nicely to trunk, so I am
attaching a new patch that fixes conflicts. They're all due to white space
changes. It should be OK for me to proceed, shouldn't it? Let me know.
{code}
1 out of 7 hunks FAILED -- saving rejects to file
test/org/apache/pig/test/TestInputOutputFileValidator.java.rej
1 out of 8 hunks FAILED -- saving rejects to file
test/org/apache/pig/test/TestLocal2.java.rej
1 out of 4 hunks FAILED -- saving rejects to file
test/org/apache/pig/test/TestNewPlanColumnPrune.java.rej
1 out of 27 hunks FAILED -- saving rejects to file
test/org/apache/pig/test/TestStore.java.rej
8 out of 21 hunks FAILED -- saving rejects to file
test/org/apache/pig/test/TestStreamingLocal.java.rej
{code}
> Modernize a chunk of the tests
> ------------------------------
>
> Key: PIG-3006
> URL: https://issues.apache.org/jira/browse/PIG-3006
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3006-0.patch, PIG-3006-1.patch, PIG-3006-2.patch,
> PIG-3006-3.patch
>
>
> A lot of the tests use antiquated patterns. My goal was to refactor them in a
> couple ways:
> - get rid of the annotation specifying Junit 4. All should use JUnit 4
> (question: where is the Junit 3 dependency even being pulled in?)
> - Nothing should extend TestCase. Everything should be annotation driven.
> - Properly use asserts. There was a lot of assertTrue(null==thing), so I
> replaced it with assertNull(thing), and so on.
> - Get rid of MiniCluster use in a handful of cases.
> I've run every test and they pass, EXCEPT TestLargeFile which is failing on
> trunk anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
