[
https://issues.apache.org/jira/browse/PIG-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487301#comment-13487301
]
Alan Gates commented on PIG-3008:
---------------------------------
A couple of notes:
We already have coding standards, see
https://cwiki.apache.org/confluence/display/PIG/HowToContribute the section on
Making Changes specifies that we use Sun's coding standards with 4 space
indention.
bq. we should also allow white space changes to a limited extend in any patch.
For example, if I am touching a method in a file, I should be able to fix white
spaces in that area of code that I'm touching regardless how long that file has
not been modified. Fixing an entire file could be disruptive, but fixing parts
of a file should be acceptable, no?
I disagree. This makes it really hard to understand real vs white space
changes when reviewing the patch. Now the reviewer has to re-read the entire
method and figure out what actually changed. I'm all for cleaning up white
space, but let's do it in separate patches.
> Fix whitespace in Pig code
> --------------------------
>
> Key: PIG-3008
> URL: https://issues.apache.org/jira/browse/PIG-3008
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: checkstyle.xml
>
>
> This JIRA exists mainly to get a conversation started. We've talked about it
> before, and it's a tricky issue. That said, some of the Pig code is super,
> super gnarly. We need some sort of path that will let it eventually be
> fix-able.
> I posit: any file that hasn't been touched for over 6 months is eligible for
> a whitespace patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
