[
https://issues.apache.org/jira/browse/PIG-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487334#comment-13487334
]
Cheolsoo Park commented on PIG-3008:
------------------------------------
I appreciate your comments Alan.
1) I am wondering if we could use the RB more often since it has an option to
hide white space changes. It might make sense to ask contributors to upload
their patches when they include white space changes.
2) I think that there are certain times when including both white space and
code changes makes more sense. Here is an example:
https://reviews.apache.org/r/7734/diff/1/#4.16. Jon is removing a try-catch
block and making some code changes at the same time. If indentations are not
fixed, the net result looks really odd. In this case, wouldn't it better to
include white space changes?
Thanks!
> Fix whitespace in Pig code
> --------------------------
>
> Key: PIG-3008
> URL: https://issues.apache.org/jira/browse/PIG-3008
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: checkstyle.xml
>
>
> This JIRA exists mainly to get a conversation started. We've talked about it
> before, and it's a tricky issue. That said, some of the Pig code is super,
> super gnarly. We need some sort of path that will let it eventually be
> fix-able.
> I posit: any file that hasn't been touched for over 6 months is eligible for
> a whitespace patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
