> On June 10, 2013, 7:06 p.m., Rohini Palaniswamy wrote: > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java, > > lines 327-338 > > <https://reviews.apache.org/r/11135/diff/5/?file=295050#file295050line327> > > > > This can be simplified into few lines
This was fixed by creating a new function which will make the code more readable. - Viraj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11135/#review21662 ----------------------------------------------------------- On May 30, 2013, 2:28 a.m., Viraj Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11135/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 2:28 a.m.) > > > Review request for pig and Rohini Palaniswamy. > > > Description > ------- > > Default values are not honoured when merging default schema > > > This addresses bug PIG-3318. > https://issues.apache.org/jira/browse/PIG-3318 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java > 1484564 > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java > 1484564 > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java > 1484564 > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java > 1484564 > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java > 1484564 > > Diff: https://reviews.apache.org/r/11135/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Viraj Bhat > >
