----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11135/#review21704 -----------------------------------------------------------
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java <https://reviews.apache.org/r/11135/#comment44865> Should be outside if else http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java <https://reviews.apache.org/r/11135/#comment44866> Do not need this variable. Can do if else on the condition http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java <https://reviews.apache.org/r/11135/#comment44867> formatting. space after , http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java <https://reviews.apache.org/r/11135/#comment44868> formatting. Code in next line - Rohini Palaniswamy On June 11, 2013, 3:04 a.m., Viraj Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11135/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 3:04 a.m.) > > > Review request for pig and Rohini Palaniswamy. > > > Description > ------- > > Default values are not honoured when merging default schema > > > This addresses bug PIG-3318. > https://issues.apache.org/jira/browse/PIG-3318 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java > 1491556 > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java > 1491556 > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java > 1491556 > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java > 1491562 > > Diff: https://reviews.apache.org/r/11135/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Viraj Bhat > >