----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16533/ -----------------------------------------------------------
(Updated Jan. 15, 2014, 12:44 a.m.) Review request for pig. Changes ------- This should address currently open issues. Reworked all of the column specification to match HBaseStorage more closely with a few differences. * Accumulo allows any number of colfams for a table which allows for different table designs. As such, I introduced the notion of "*" which consumes all columns in a row as a map. If the user enters no columns (empty string), this is also the default behavior. "literal" or "literal:literal" create a DataByteArray in the tuple, and "liter*", "literal:" and "literal:*" all create a map in the tuple. * Removed string-ification serialization in AccumuloBinaryConvert. * Even more unit tests. Bugs: PIG-3573 https://issues.apache.org/jira/browse/PIG-3573 Repository: pig-git Description ------- Provides basic StoreFunc and LoadFunc implementations. Based off of code that was in an Accumulo contrib project. Diffs (updated) ----- ivy.xml 180eb2c ivy/libraries.properties 14abdf8 src/org/apache/pig/backend/hadoop/accumulo/AbstractAccumuloStorage.java PRE-CREATION src/org/apache/pig/backend/hadoop/accumulo/AccumuloBinaryConverter.java PRE-CREATION src/org/apache/pig/backend/hadoop/accumulo/AccumuloStorage.java PRE-CREATION src/org/apache/pig/backend/hadoop/accumulo/AccumuloStorageOptions.java PRE-CREATION src/org/apache/pig/backend/hadoop/accumulo/Column.java PRE-CREATION src/org/apache/pig/backend/hadoop/accumulo/FixedByteArrayOutputStream.java PRE-CREATION src/org/apache/pig/backend/hadoop/accumulo/Utils.java PRE-CREATION test/excluded-tests-23 aaf6bd1 test/org/apache/pig/backend/hadoop/accumulo/TestAbstractAccumuloStorage.java PRE-CREATION test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloBinaryConverter.java PRE-CREATION test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloColumns.java PRE-CREATION test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloPigCluster.java PRE-CREATION test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloStorage.java PRE-CREATION test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloStorageConfiguration.java PRE-CREATION test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloStorageOptions.java PRE-CREATION Diff: https://reviews.apache.org/r/16533/diff/ Testing ------- Local tests reading, writing and JOIN'ing Accumulo tables. Tested against Hadoop-1.0.4 and 2.2.0, with Accumulo 1.5.0 Thanks, Josh Elser