-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16533/#review31974
-----------------------------------------------------------
Ship it!
Excellent job!
The only thing I find is we still need getLoadCaster in
AbstractAccumuloStorage.java
@Override
public LoadCaster getLoadCaster() throws IOException {
return caster;
}
I can add it before commit if you don't mind.
- Daniel Dai
On Jan. 15, 2014, 12:44 a.m., Josh Elser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16533/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 12:44 a.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-3573
> https://issues.apache.org/jira/browse/PIG-3573
>
>
> Repository: pig-git
>
>
> Description
> -------
>
> Provides basic StoreFunc and LoadFunc implementations. Based off of code that
> was in an Accumulo contrib project.
>
>
> Diffs
> -----
>
> ivy.xml 180eb2c
> ivy/libraries.properties 14abdf8
> src/org/apache/pig/backend/hadoop/accumulo/AbstractAccumuloStorage.java
> PRE-CREATION
> src/org/apache/pig/backend/hadoop/accumulo/AccumuloBinaryConverter.java
> PRE-CREATION
> src/org/apache/pig/backend/hadoop/accumulo/AccumuloStorage.java
> PRE-CREATION
> src/org/apache/pig/backend/hadoop/accumulo/AccumuloStorageOptions.java
> PRE-CREATION
> src/org/apache/pig/backend/hadoop/accumulo/Column.java PRE-CREATION
> src/org/apache/pig/backend/hadoop/accumulo/FixedByteArrayOutputStream.java
> PRE-CREATION
> src/org/apache/pig/backend/hadoop/accumulo/Utils.java PRE-CREATION
> test/excluded-tests-23 aaf6bd1
>
> test/org/apache/pig/backend/hadoop/accumulo/TestAbstractAccumuloStorage.java
> PRE-CREATION
>
> test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloBinaryConverter.java
> PRE-CREATION
> test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloColumns.java
> PRE-CREATION
> test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloPigCluster.java
> PRE-CREATION
> test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloStorage.java
> PRE-CREATION
>
> test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloStorageConfiguration.java
> PRE-CREATION
> test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloStorageOptions.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16533/diff/
>
>
> Testing
> -------
>
> Local tests reading, writing and JOIN'ing Accumulo tables. Tested against
> Hadoop-1.0.4 and 2.2.0, with Accumulo 1.5.0
>
>
> Thanks,
>
> Josh Elser
>
>
