----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17878/#review34061 -----------------------------------------------------------
TestTezCompiler golden files will need updating. branches/tez/src/org/apache/pig/impl/builtin/ReadScalarsTez.java <https://reviews.apache.org/r/17878/#comment64048> 1) Need to handle case where scalar is null here. 2) Need to handle case where scalar has more than one record and throw error. It would be better to do that while writing scalar itself instead of here as we have better control now. This would avoid cases where wrong usage of scalars can bring down namenode. branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/MultiQueryOptimizerTez.java <https://reviews.apache.org/r/17878/#comment64785> Can we create a jira to do this later? Currently nested splits work. branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezCompiler.java <https://reviews.apache.org/r/17878/#comment64779> It would be easier to keep this here for curTezOp.getSplitParent() != null (no multiquery) branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezCompiler.java <https://reviews.apache.org/r/17878/#comment64776> You will need these, else there will be hanging operators in the plan branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezCompiler.java <https://reviews.apache.org/r/17878/#comment64778> You will need this as well, else input will be pointing to wrong physical operataors. branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java <https://reviews.apache.org/r/17878/#comment64780> Might be easier if this optimizer is the first one to be called before Combiner and secondary key optimizer. Just a thought. If there are no issues with having it later, then fine. - Rohini Palaniswamy On Feb. 17, 2014, 4:25 a.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17878/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2014, 4:25 a.m.) > > > Review request for pig, Cheolsoo Park and Rohini Palaniswamy. > > > Bugs: PIG-3757 > https://issues.apache.org/jira/browse/PIG-3757 > > > Repository: pig > > > Description > ------- > > See PIG-3757 > > > Diffs > ----- > > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhyPlanVisitor.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/CombinerPackager.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/MultiQueryOptimizerTez.java > PRE-CREATION > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/PigProcessor.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/SecondaryKeyOptimizerTez.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezCompiler.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezOperator.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/util/TezCompilerUtil.java > 1567297 > branches/tez/src/org/apache/pig/impl/builtin/ReadScalarsTez.java > PRE-CREATION > branches/tez/src/org/apache/pig/newplan/logical/visitor/ScalarVisitor.java > 1567297 > > Diff: https://reviews.apache.org/r/17878/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
