----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17878/#review34634 -----------------------------------------------------------
Ship it! Discussed with Daniel offline. Since this patch makes a lot of change and fixing all cases would take some time, better to check this in its current state and continue fixing it in a separate jira. I already checked in PIG-3766 and this patch has to be rebased. It will be time consuming to rebase again and again and work on this patch as other patches go in as this patch makes a lot of changes to TezCompiler. - Rohini Palaniswamy On Feb. 17, 2014, 4:25 a.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17878/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2014, 4:25 a.m.) > > > Review request for pig, Cheolsoo Park and Rohini Palaniswamy. > > > Bugs: PIG-3757 > https://issues.apache.org/jira/browse/PIG-3757 > > > Repository: pig > > > Description > ------- > > See PIG-3757 > > > Diffs > ----- > > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhyPlanVisitor.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/CombinerPackager.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/MultiQueryOptimizerTez.java > PRE-CREATION > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/PigProcessor.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/SecondaryKeyOptimizerTez.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezCompiler.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezOperator.java > 1567297 > > branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/util/TezCompilerUtil.java > 1567297 > branches/tez/src/org/apache/pig/impl/builtin/ReadScalarsTez.java > PRE-CREATION > branches/tez/src/org/apache/pig/newplan/logical/visitor/ScalarVisitor.java > 1567297 > > Diff: https://reviews.apache.org/r/17878/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
