OK, thanks for doing the testing, I cannot think of other use cases to test right now, unless someone else chimes in.
-Subbu On 2020/05/19 22:34:43, Neha Pawar <[email protected]> wrote: > I think we should include it in this release > 1. It will not affect existing schemas. I just completed the upgrade > scenario testing suggested by Subbu. I've added the steps and the results > in the PR > https://github.com/apache/incubator-pinot/pull/5399#issuecomment-631114033 > 2. For users of 0.4.0 we can encourage them to use only DateTimeFieldSpec. > It is possible we find some issues in that, because they'll be the first > real users. In that case, they can always keep using TimeFieldSpec and we > fix the issues in 0.5.0. > 3. If we do not include this change in this release, we will not even find > out the issues in using only DateTimeFieldSpec, because all the production > setups will still be using the old schemas. They will only help in testing > that the old schemas work. > 4. If we push this to 0.5.0, the Phase 2 (true deprecation) will get pushed > to 0.6.0 > > <[email protected]> > > > On Tue, May 19, 2020 at 10:28 AM kishore g <[email protected]> wrote: > > > If we have thought of all the cases and know that it won't impact existing > > - why delay it to the next release?. The earlier we start pushing users to > > use datetimespec the better it is for us. > > > > On Tue, May 19, 2020 at 10:20 AM Subbu Subramaniam <[email protected]> > > wrote: > > > > > I meant to suggest release 0.4.0 excluding PR 5399 (date time spec) > > > > > > -Subbu > > > > > > On 2020/05/19 17:18:13, Subbu Subramaniam <[email protected]> wrote: > > > > On the other hand, it may be wise to release 0.4.0 without this change. > > > > > > > > Those of us who pick up changes regularly from the master can verify > > > that there is no incompatibility inadvertently introduced by this change > > > (Not everything can be caught by review) > > > > > > > > And then we can push this change in 0.5.0, not worrying about another > > > backward incomaptibility introduced trying to fix a previous incompat. > > > > > > > > My suggestion > > > > > > > > -Subbu > > > > > > > > On 2020/05/19 16:36:16, Neha Pawar <[email protected]> wrote: > > > > > Please let's wait for > > > https://github.com/apache/incubator-pinot/pull/5399 the > > > > > DateTimeFieldSpec support. I have 2 reviews, waiting on just 1 more. > > > > > Will keep you posted. > > > > > > > > > > Thanks, > > > > > *Neha Pawar* > > > > > > > > > > <[email protected]> > > > > > > > > > > > > > > > On Sun, May 17, 2020 at 6:03 PM H <[email protected]> wrote: > > > > > > > > > > > Will wait for a few more diffs and revisit the release the coming > > > week. > > > > > > Please let me know if you are planning on some diffs and would like > > > to get > > > > > > them in the release. > > > > > > > > > > > > On Thu, May 14, 2020 at 8:09 PM H <[email protected]> wrote: > > > > > > > > > > > > > Thanks for letting me know Mayank! > > > > > > > > > > > > > > On Thu, May 14, 2020 at 4:43 PM Mayank Shrivastava > > > > > > > <[email protected]> wrote: > > > > > > > > > > > > > >> I am done with the initial implementation of ThetaSketch, the > > last > > > > > > commit > > > > > > >> happened yesterday. > > > > > > >> > > > > > > >> Cheers, > > > > > > >> Mayank > > > > > > >> ________________________________ > > > > > > >> From: Mayank Shrivastava <[email protected]> > > > > > > >> Sent: Wednesday, May 13, 2020 10:33 AM > > > > > > >> To: [email protected] <[email protected]> > > > > > > >> Subject: Re: Preparing for the upcoming Pinot 0.4.0 release > > > > > > >> > > > > > > >> While ThetaSketch major checkins have gone in, I am still > > working > > > on > > > > > > >> making it work end to end. Will update on progress by EoD > > > tomorrow. > > > > > > >> > > > > > > >> Thanks, > > > > > > >> Mayank > > > > > > >> ________________________________ > > > > > > >> From: H <[email protected]> > > > > > > >> Sent: Tuesday, May 12, 2020 9:23 PM > > > > > > >> To: [email protected] <[email protected]> > > > > > > >> Subject: Re: Preparing for the upcoming Pinot 0.4.0 release > > > > > > >> > > > > > > >> Bumping this thread for 0.4.0 release. > > > > > > >> > > > > > > >> The features called out earlier are either merged or close to > > > being > > > > > > >> merged. > > > > > > >> Kudos to the feature owners for making it in. > > > > > > >> > > > > > > >> I plan to use the master branch as of this *coming Friday May > > > 15th, 7pm > > > > > > >> PST* as > > > > > > >> the release candidate. > > > > > > >> > > > > > > >> I will send another email with the branch info before cutting > > the > > > > > > release. > > > > > > >> Please let me know if there are questions or concerns. > > > > > > >> > > > > > > >> Thanks, > > > > > > >> Haibo > > > > > > >> > > > > > > >> On Wed, Apr 29, 2020 at 10:11 PM H <[email protected]> wrote: > > > > > > >> > > > > > > >> > Sounds good. Will revisit this next week. > > > > > > >> > > > > > > > >> > On Wed, Apr 29, 2020 at 22:08 kishore g <[email protected]> > > > wrote: > > > > > > >> > > > > > > > >> >> Let’s wait for another week. > > > > > > >> >> Want to get the following features > > > > > > >> >> In > > > > > > >> >> - theta sketch > > > > > > >> >> - post Agg > > > > > > >> >> - range index > > > > > > >> >> - timespec to datetimespec > > > > > > >> >> > > > > > > >> >> > > > > > > >> >> On Wed, Apr 29, 2020 at 9:44 PM H <[email protected]> > > wrote: > > > > > > >> >> > > > > > > >> >> > Hi Pinot community, > > > > > > >> >> > > > > > > > >> >> > I'm preparing for the upcoming Pinot 0.4.0 release. I plan > > > to use > > > > > > the > > > > > > >> >> > master branch as of this coming Friday May 1st, 7pm PST. > > > > > > >> >> > > > > > > > >> >> > I will send another email with the branch info before > > > cutting the > > > > > > >> >> > release. Please let me know if there are questions or > > > concerns. > > > > > > >> >> > > > > > > > >> >> > Thanks, > > > > > > >> >> > Haibo > > > > > > >> >> > > > > > > > >> >> > > > > > > >> > -- > > > > > > >> > Sent from my iPhone > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
