[ https://issues.apache.org/jira/browse/PIVOT-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014455#comment-16014455 ]
Roger Whitcomb commented on PIVOT-997: -------------------------------------- First set of changes in "trunk": Sending tutorials\src\org\apache\pivot\tutorials\bxmlexplorer\FakeWindow.java Sending wtk\src\org\apache\pivot\wtk\Accordion.java Sending wtk\src\org\apache\pivot\wtk\TabPane.java Sending wtk\src\org\apache\pivot\wtk\TablePane.java Sending wtk\src\org\apache\pivot\wtk\TableView.java Sending wtk\src\org\apache\pivot\wtk\TableViewHeader.java Sending wtk\src\org\apache\pivot\wtk\TextArea.java Sending wtk\src\org\apache\pivot\wtk\TextInput.java Adding wtk\src\org\apache\pivot\wtk\TextInputMethodListener.java Sending wtk\src\org\apache\pivot\wtk\TextPane.java Sending wtk\src\org\apache\pivot\wtk\TreeView.java Sending wtk\src\org\apache\pivot\wtk\VFSBrowser.java Sending wtk\src\org\apache\pivot\wtk\VFSBrowserSheet.java Sending wtk\src\org\apache\pivot\wtk\Viewport.java Sending wtk\src\org\apache\pivot\wtk\WTKListenerList.java Sending wtk\src\org\apache\pivot\wtk\Window.java Transmitting file data ................done Committing transaction... Committed revision 1795435. > Deprecate (and eventually remove) the WTKListenerList class, which is > currently empty > ------------------------------------------------------------------------------------- > > Key: PIVOT-997 > URL: https://issues.apache.org/jira/browse/PIVOT-997 > Project: Pivot > Issue Type: Improvement > Components: wtk > Affects Versions: 2.1 > Environment: All > Reporter: Roger Whitcomb > Assignee: Roger Whitcomb > Priority: Minor > > The WTKListenerList class was originally added as a subclass of ListenerList, > but with thread-safety checks in it (basically checking that all the > operations were performed on the Event Dispatch Thread (EDT) or "main" during > startup). All these checks were removed some time ago, so that component > hierarchies could be built "offline", that is in a background thread, either > by BXMLSerializer, or programmatically. This left WTKListenerList as an > empty class, but with comments to the effect that it was used to provide > thread safety checks.... This is confusing, and unnecessary. So, I propose > to deprecate the class in version 2.1, replacing all the internal references > with just "ListenerList", and so the class can be removed at some point after > that. > Note: deprecating it in the 2.0.x branch is not really an option, since it > means the build gets 100s of warnings about the deprecation, which is not > good for a release branch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)