[ https://issues.apache.org/jira/browse/PIVOT-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014555#comment-16014555 ]
Roger Whitcomb commented on PIVOT-997: -------------------------------------- Final set of changes in "trunk". Now all of the references to WTKListenerList have been replaced with "ListenerList": Sending wtk\src\org\apache\pivot\wtk\Action.java Sending wtk\src\org\apache\pivot\wtk\ActivityIndicator.java Sending wtk\src\org\apache\pivot\wtk\Alert.java Sending wtk\src\org\apache\pivot\wtk\Border.java Sending wtk\src\org\apache\pivot\wtk\BoxPane.java Sending wtk\src\org\apache\pivot\wtk\Button.java Sending wtk\src\org\apache\pivot\wtk\ButtonGroup.java Sending wtk\src\org\apache\pivot\wtk\Calendar.java Sending wtk\src\org\apache\pivot\wtk\CalendarButton.java Sending wtk\src\org\apache\pivot\wtk\CardPane.java Sending wtk\src\org\apache\pivot\wtk\ColorChooser.java Sending wtk\src\org\apache\pivot\wtk\ColorChooserButton.java Sending wtk\src\org\apache\pivot\wtk\Component.java Sending wtk\src\org\apache\pivot\wtk\Container.java Transmitting file data ..............done Committing transaction... Committed revision 1795442. > Deprecate (and eventually remove) the WTKListenerList class, which is > currently empty > ------------------------------------------------------------------------------------- > > Key: PIVOT-997 > URL: https://issues.apache.org/jira/browse/PIVOT-997 > Project: Pivot > Issue Type: Improvement > Components: wtk > Affects Versions: 2.1 > Environment: All > Reporter: Roger Whitcomb > Assignee: Roger Whitcomb > Priority: Minor > > The WTKListenerList class was originally added as a subclass of ListenerList, > but with thread-safety checks in it (basically checking that all the > operations were performed on the Event Dispatch Thread (EDT) or "main" during > startup). All these checks were removed some time ago, so that component > hierarchies could be built "offline", that is in a background thread, either > by BXMLSerializer, or programmatically. This left WTKListenerList as an > empty class, but with comments to the effect that it was used to provide > thread safety checks.... This is confusing, and unnecessary. So, I propose > to deprecate the class in version 2.1, replacing all the internal references > with just "ListenerList", and so the class can be removed at some point after > that. > Note: deprecating it in the 2.0.x branch is not really an option, since it > means the build gets 100s of warnings about the deprecation, which is not > good for a release branch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)