[
https://issues.apache.org/jira/browse/PIVOT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250550#comment-16250550
]
Roger Whitcomb commented on PIVOT-1012:
---------------------------------------
More cleanup:
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraSpinnerSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraSplitPaneSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraSuggestionPopupSkin.java
Transmitting file data ...done
Committing transaction...
Committed revision 1815161.
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraScrollBarSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraScrollPaneCornerSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraSheetSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraSliderSkin.java
Transmitting file data ....done
Committing transaction...
Committed revision 1815163.
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraMeterSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraPaletteSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraPanoramaSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraPromptSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraPushButtonSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraRadioButtonSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraRollupSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraTabPaneSkin.java
Transmitting file data ........done
Committing transaction...
Committed revision 1815164.
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraCheckboxSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraColorChooserButtonSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraExpanderSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraLinkButtonSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraListButtonSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraMenuBarSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraMenuSkin.java
Transmitting file data .......done
Committing transaction...
Committed revision 1815165.
> Many places throw IllegalArgumentException during parameter validation, but
> some are inconsistent
> -------------------------------------------------------------------------------------------------
>
> Key: PIVOT-1012
> URL: https://issues.apache.org/jira/browse/PIVOT-1012
> Project: Pivot
> Issue Type: Improvement
> Components: core, wtk, wtk-terra
> Environment: All
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.1
>
>
> Primarily the code looks like this currently:
> {code:java}
> if (param == null)
> throw new IllegalArgumentException(param + " is null");
> {code}
> But not all places have the message in the exception, and not all places
> check the parameters as they should, and not all places have the same message.
> So, regularize this checking everywhere by making common "core" methods to do
> this null check (or other checks, such as <= 0, etc.) so that the checking
> and messaging are common. This also simplifies the code, and with JIT
> compiling shouldn't affect runtime speed either, as this common method should
> get compiled and/or inlined as appropriate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
