[
https://issues.apache.org/jira/browse/PIVOT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250584#comment-16250584
]
Roger Whitcomb commented on PIVOT-1012:
---------------------------------------
Misc. cleanup here:
Sending tutorials\src\org\apache\pivot\tutorials\explorer\Ruler.java
Sending tutorials\src\org\apache\pivot\tutorials\navigation\Ruler.java
Transmitting file data ..done
Committing transaction...
Committed revision 1815168.
Sending wtk\src\org\apache\pivot\wtk\effects\ScaleDecorator.java
Transmitting file data .done
Committing transaction...
Committed revision 1815169.
Sending wtk\src\org\apache\pivot\wtk\BrowserApplicationContext.java
Sending wtk\src\org\apache\pivot\wtk\Component.java
Transmitting file data ..done
Committing transaction...
Committed revision 1815170.
Finally here:
Sending demos\src\org\apache\pivot\demos\itunes\SearchDemo.java
Sending demos\src\org\apache\pivot\demos\xml\NodeRenderer.java
Sending tests\src\org\apache\pivot\tests\JavascriptConsoleTest.java
Sending tests\src\org\apache\pivot\tests\issues\Pivot694.java
Sending
tutorials\src\org\apache\pivot\tutorials\bxmlexplorer\FakeWindowSkin.java
Sending
tutorials\src\org\apache\pivot\tutorials\webqueries\AmountBindMapping.java
Transmitting file data ......done
Committing transaction...
Committed revision 1815171.
> Many places throw IllegalArgumentException during parameter validation, but
> some are inconsistent
> -------------------------------------------------------------------------------------------------
>
> Key: PIVOT-1012
> URL: https://issues.apache.org/jira/browse/PIVOT-1012
> Project: Pivot
> Issue Type: Improvement
> Components: core, wtk, wtk-terra
> Environment: All
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.1
>
>
> Primarily the code looks like this currently:
> {code:java}
> if (param == null)
> throw new IllegalArgumentException(param + " is null");
> {code}
> But not all places have the message in the exception, and not all places
> check the parameters as they should, and not all places have the same message.
> So, regularize this checking everywhere by making common "core" methods to do
> this null check (or other checks, such as <= 0, etc.) so that the checking
> and messaging are common. This also simplifies the code, and with JIT
> compiling shouldn't affect runtime speed either, as this common method should
> get compiled and/or inlined as appropriate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
