[ https://issues.apache.org/jira/browse/PIVOT-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309203#comment-16309203 ]
Roger Whitcomb commented on PIVOT-1020: --------------------------------------- More work: adding styles and updating renderers: Sending examples\src\org\apache\pivot\examples\wrapping\WrappingButtonDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\Component.java Sending wtk\src\org\apache\pivot\wtk\Style.java Sending wtk\src\org\apache\pivot\wtk\content\AccordionHeaderDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\ButtonData.java Sending wtk\src\org\apache\pivot\wtk\content\ButtonDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\LinkButtonDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\ListButtonDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\ListItem.java Sending wtk\src\org\apache\pivot\wtk\content\MenuBarItemDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\MenuButtonDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\MenuItemData.java Sending wtk\src\org\apache\pivot\wtk\content\MenuItemDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\TableViewHeaderData.java Sending wtk\src\org\apache\pivot\wtk\content\TableViewHeaderDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\TreeNode.java Sending wtk\src\org\apache\pivot\wtk\text\ComponentNode.java Transmitting file data .................done Committing transaction... Committed revision 1819929. > Introduce a "Style" enum for compile-time checking of style names > ----------------------------------------------------------------- > > Key: PIVOT-1020 > URL: https://issues.apache.org/jira/browse/PIVOT-1020 > Project: Pivot > Issue Type: Improvement > Components: wtk > Reporter: Roger Whitcomb > Assignee: Roger Whitcomb > Priority: Minor > Fix For: 2.1 > > > Many places use hard-coded strings for component style names, and a number of > which are fairly common ("font", "color", "horizontalAlignment"). It would > reduce the possibility of misspelling of these style names if there were an > enum for them so that the Java compiler would check spelling instead of > finding out at runtime that the style name was misspelled. > This would involve adding methods to Component.StyleDictionary to deal with > the enum as a key. -- This message was sent by Atlassian JIRA (v6.4.14#64029)