[ https://issues.apache.org/jira/browse/PIVOT-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355749#comment-16355749 ]
Roger Whitcomb commented on PIVOT-1020: --------------------------------------- All the demos, tests, and tutorials: Sending demos\src\org\apache\pivot\demos\dom\DOMInteractionDemo.java Sending demos\src\org\apache\pivot\demos\json\JSONViewer.java Sending demos\src\org\apache\pivot\demos\styles\ColorSchemeBuilderWindow.java Sending demos\src\org\apache\pivot\demos\text\TextPaneDemo.java Sending demos\src\org\apache\pivot\demos\xml\NodeRenderer.java Sending demos\src\org\apache\pivot\demos\xml\XMLViewer.java Sending tests\src\org\apache\pivot\tests\CardPaneTest.java Sending tests\src\org\apache\pivot\tests\ColorPaletteTest.java Sending tests\src\org\apache\pivot\tests\DataBindingTest.java Sending tests\src\org\apache\pivot\tests\DragDropTest.java Sending tests\src\org\apache\pivot\tests\FileBrowserWithCharsetTest.java Sending tests\src\org\apache\pivot\tests\LabelAntialiasTest.java Sending tests\src\org\apache\pivot\tests\LabelTest.java Sending tests\src\org\apache\pivot\tests\LinkButtonTest.java Sending tests\src\org\apache\pivot\tests\NativeDragDropTest.java Sending tests\src\org\apache\pivot\tests\PromptTest.java Sending tests\src\org\apache\pivot\tests\PushButtonTest.java Sending tests\src\org\apache\pivot\tests\SheetTest.java Sending tests\src\org\apache\pivot\tests\SplashScreenTest.java Sending tests\src\org\apache\pivot\tests\VFSBrowserTest.java Sending tests\src\org\apache\pivot\tests\WindowTest.java Sending tests\src\org\apache\pivot\tests\issues\Pivot734.java Sending tests\src\org\apache\pivot\tests\issues\Pivot734WithWorkaround.java Sending tests\src\org\apache\pivot\tests\issues\Pivot811.java Sending tests\src\org\apache\pivot\tests\issues\pivot894\Pivot894.java Sending tutorials\src\org\apache\pivot\tutorials\HelloJava.java Sending tutorials\src\org\apache\pivot\tutorials\KitchenSink.java Sending tutorials\src\org\apache\pivot\tutorials\bxmlexplorer\FakeWindowSkin.java Sending tutorials\src\org\apache\pivot\tutorials\explorer\tools\ComponentInspectorSkin.java Sending tutorials\src\org\apache\pivot\tutorials\filebrowsing\FileBrowsing.java Sending tutorials\src\org\apache\pivot\tutorials\hello_javascript.bxml Sending tutorials\src\org\apache\pivot\tutorials\layout\BoxPanes.java Sending tutorials\src\org\apache\pivot\tutorials\layout\FlowPanes.java Sending tutorials\src\org\apache\pivot\tutorials\layout\TablePanes.java Sending tutorials\src\org\apache\pivot\tutorials\layout\split_panes.bxml Sending tutorials\src\org\apache\pivot\tutorials\layout\table_panes.bxml Sending tutorials\src\org\apache\pivot\tutorials\layout\table_panes_configure_cell.bxml Sending tutorials\src\org\apache\pivot\tutorials\lists\ListButtons.java Sending tutorials\src\org\apache\pivot\tutorials\lists\RepeatableListButtons.java Sending tutorials\src\org\apache\pivot\tutorials\navigation\CardPanes.java Sending tutorials\src\org\apache\pivot\tutorials\navigation\TabPanes.java Sending tutorials\src\org\apache\pivot\tutorials\stocktracker\ChangeCellRenderer.java Sending tutorials\www\box-panes.xml Sending tutorials\www\card-panes.xml Sending tutorials\www\file-browsing.xml Sending tutorials\www\flow-panes.xml Sending tutorials\www\hello-bxml.xml Sending tutorials\www\hello-world.xml Sending tutorials\www\list-buttons.xml Sending tutorials\www\repeatable-list-buttons.xml Sending tutorials\www\split-panes.xml Sending tutorials\www\tab-panes.xml Sending tutorials\www\web-queries.xml Sending wtk\src\org\apache\pivot\wtk\Style.java Transmitting file data ......................................................done Committing transaction... Committed revision 1823503. > Introduce a "Style" enum for compile-time checking of style names > ----------------------------------------------------------------- > > Key: PIVOT-1020 > URL: https://issues.apache.org/jira/browse/PIVOT-1020 > Project: Pivot > Issue Type: Improvement > Components: wtk > Reporter: Roger Whitcomb > Assignee: Roger Whitcomb > Priority: Minor > Fix For: 2.1 > > > Many places use hard-coded strings for component style names, and a number of > which are fairly common ("font", "color", "horizontalAlignment"). It would > reduce the possibility of misspelling of these style names if there were an > enum for them so that the Java compiler would check spelling instead of > finding out at runtime that the style name was misspelled. > This would involve adding methods to Component.StyleDictionary to deal with > the enum as a key. -- This message was sent by Atlassian JIRA (v7.6.3#76005)