[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781576#comment-17781576
]
Roger Lee Whitcomb commented on PIVOT-1032:
-------------------------------------------
Last set of pending changes on my systems (sigh):
Sending core/src/org/apache/pivot/collections/HashSet.java
Sending core/src/org/apache/pivot/util/StringUtils.java
Sending core/src/org/apache/pivot/util/Utils.java
Sending core/src/org/apache/pivot/util/concurrent/Task.java
Sending core/src/org/apache/pivot/util/concurrent/TimeoutException.java
Sending core/test/org/apache/pivot/util/test/StringUtilsTest.java
Sending tests/src/org/apache/pivot/tests/console_test.bxml
Sending wtk/src/org/apache/pivot/wtk/Button.java
Sending wtk/src/org/apache/pivot/wtk/Keyboard.java
Sending wtk/src/org/apache/pivot/wtk/TextInput.java
Sending wtk/src/org/apache/pivot/wtk/TextInputListener.java
Sending wtk/src/org/apache/pivot/wtk/skin/DisplaySkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinListItemView.java
Sending
wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinNumberedListView.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraGaugeSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTextInputSkin.java
Transmitting file data .................done
Committing transaction...
Committed revision 1913476.
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Lee Whitcomb
> Assignee: Roger Lee Whitcomb
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
