[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408556#comment-17408556
]
Roger Lee Whitcomb commented on PIVOT-1032:
-------------------------------------------
Some more tweaks to the StyleChecks program:
* the main method was too long
* display separators in counts
* properly display long names in the category list for any duplicates in any
category
* fix the "-f" processing to accept the leading paths
* spiff up the top banner
PIVOT-1032: The main method of StyleChecks was too long, counts need 1000s
separators,
properly display long/short names in the file names list if any are duplicates.
Handle
files with the same name properly for the "-f" option. Spiff up the top banner.
Sending StyleChecks.java
Transmitting file data .done
Committing transaction...
Committed revision 1892800.
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Lee Whitcomb
> Assignee: Roger Lee Whitcomb
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
